language cleanups #147
Closed
language cleanups #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaned imports updated assertregexpmatches to assertregex simplied if checks tidied whitespace
|
New assert function name is required for Python 3.12 compat. |
Collaborator
|
First, I want to say thank you for your support. It's important even for small libraries like At the same time, it would be nice if you could update your changes for the current version. There are some conflicts. It would be nice to have a PR without them. P.S. Library creator is a busy person. Finally, I'm here and want to push it a little further. |
Author
|
Understood. What I might do is close this PR and make a new one with updated changes for the new versions of python too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaned imports
updated assertregexpmatches to assertregex
simplied if checks
tidied whitespace